[PATCH 1/1] opal: fix tests dependency on libfdt

Erico Nunes ernunes at redhat.com
Fri May 26 16:21:14 UTC 2017


Hi Colin,

On 05/25/2017 05:52 PM, Colin Ian King wrote:
> I've not got the resources to test this. Pridhiviraj does this work for you?

I understand that the opal tests being touched here are targeted for
power platforms, but this patch should only impact the fwts build. So, I
see the following tests that can be done on x86_64:

- Build fwts without libfdt installed in the system: broken without this
patch. With the patch, the build succeeds and the mem_info and
power_mgmt tests are not included because libfdt is unavailable. They do
not show up in 'fwts --show-tests'.

- Build fwts with libfdt (and libfdt headers): not afected, the mem_info
and power_mgmt tests show up in 'fwts --show-tests':
mem_info        OPAL MEM Info
power_mgmt      OPAL Processor Power Management DT Validation Tests


Optional libfdt dependency was already in place for other DT-dependant
tests such as 'dt_base  Base device tree validity check' or 'reserv_mem
OPAL Reserved memory DT Validation Test'. So this patch only places
mem_info and power_mgmt correctly in the build to avoid turning libfdt
from being optional to being mandatory needlessly.


Erico



More information about the fwts-devel mailing list