ACK: [PATCH] dmi: dmicheck: zero buffer buf, cleans up a static analysis warning

Alex Hung alex.hung at canonical.com
Mon Nov 13 03:29:00 UTC 2017


On 2017-11-11 01:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> This is not strictly necessary, but it cleans up a static analysis warning
> from CoverityScan.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>   src/dmi/dmicheck/dmicheck.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index a55597f1..9bc8804c 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -306,6 +306,8 @@ static int dmi_load_file(const char* filename, void *buf, size_t size)
>   	int fd;
>   	ssize_t ret;
>   
> +	(void)memset(buf, 0, size);
> +
>   	if ((fd = open(filename, O_RDONLY)) < 0)
>   		return FWTS_ERROR;
>   	ret = read(fd, buf, size);
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list