[PATCH 2/2] acpi: devices: add a new test for acpi ec device
Alex Hung
alex.hung at canonical.com
Thu Oct 5 00:20:36 UTC 2017
Signed-off-by: Alex Hung <alex.hung at canonical.com>
---
src/Makefile.am | 1 +
src/acpi/devices/ec/ec.c | 266 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 267 insertions(+)
create mode 100644 src/acpi/devices/ec/ec.c
diff --git a/src/Makefile.am b/src/Makefile.am
index cda0a49..fb224ad 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -48,6 +48,7 @@ fwts_SOURCES = main.c \
acpi/devices/ac_adapter/ac.c \
acpi/devices/battery/battery.c \
acpi/devices/battery/smart_battery.c \
+ acpi/devices/ec/ec.c \
acpi/acpidump/acpidump.c \
acpi/acpiinfo/acpiinfo.c \
acpi/acpitables/acpitables.c \
diff --git a/src/acpi/devices/ec/ec.c b/src/acpi/devices/ec/ec.c
new file mode 100644
index 0000000..a7ff5de
--- /dev/null
+++ b/src/acpi/devices/ec/ec.c
@@ -0,0 +1,266 @@
+/*
+ * Copyright (C) 2017 Canonical
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ *
+ */
+#include "fwts.h"
+
+#if defined(FWTS_HAS_ACPI)
+
+#include "fwts_acpi_object_eval.h"
+#include <stdlib.h>
+#include <stdio.h>
+#include <unistd.h>
+#include <inttypes.h>
+#include <string.h>
+
+#define FWTS_ACPI_EC_HID "PNP0C09"
+
+static ACPI_HANDLE device;
+
+static ACPI_STATUS get_device_handle(ACPI_HANDLE handle, uint32_t level,
+ void *context, void **ret_val)
+{
+ FWTS_UNUSED(level);
+ FWTS_UNUSED(context);
+ FWTS_UNUSED(ret_val);
+
+ device = handle;
+ return AE_CTRL_TERMINATE;
+}
+
+static int acpi_ec_init(fwts_framework *fw)
+{
+ ACPI_STATUS status;
+
+ if (fwts_acpica_init(fw) != FWTS_OK)
+ return FWTS_ERROR;
+
+ status = AcpiGetDevices(FWTS_ACPI_EC_HID, get_device_handle, NULL, NULL);
+ if (ACPI_FAILURE(status)) {
+ fwts_log_error(fw, "Cannot find the ACPI device");
+ return FWTS_ERROR;
+ }
+
+ if (!device) {
+ fwts_log_error(fw, "ACPI EC device does not exist, skipping test");
+ return FWTS_SKIP;
+ } else {
+ ACPI_BUFFER buffer;
+ char full_name[128];
+
+ buffer.Length = sizeof(full_name);
+ buffer.Pointer = full_name;
+
+ status = AcpiGetName(device, ACPI_FULL_PATHNAME, &buffer);
+ if (ACPI_SUCCESS(status)) {
+ fwts_log_info_verbatim(fw, "ACPI EC Device: %s", full_name);
+ fwts_log_nl(fw);
+ }
+ }
+
+ return FWTS_OK;
+}
+
+static void method_test_HID_return(
+ fwts_framework *fw,
+ char *name,
+ ACPI_BUFFER *buf,
+ ACPI_OBJECT *obj,
+ void *private)
+{
+ char tmp[8];
+
+ FWTS_UNUSED(buf);
+ FWTS_UNUSED(private);
+
+ if (obj == NULL) {
+ fwts_method_failed_null_object(fw, name, "a buffer or integer");
+ return;
+ }
+
+ switch (obj->Type) {
+ case ACPI_TYPE_STRING:
+ if (obj->String.Pointer) {
+ if (fwts_method_valid_HID_string(obj->String.Pointer))
+ fwts_passed(fw,
+ "%s returned a string '%s' "
+ "as expected.",
+ name, obj->String.Pointer);
+ else
+ fwts_failed(fw, LOG_LEVEL_MEDIUM,
+ "MethodHIDInvalidString",
+ "%s returned a string '%s' "
+ "but it was not a valid PNP ID or a "
+ "valid ACPI ID.",
+ name, obj->String.Pointer);
+ } else {
+ fwts_failed(fw, LOG_LEVEL_MEDIUM,
+ "Method_HIDNullString",
+ "%s returned a NULL string.", name);
+ }
+ break;
+ case ACPI_TYPE_INTEGER:
+ if (fwts_method_valid_EISA_ID((uint32_t)obj->Integer.Value,
+ tmp, sizeof(tmp)))
+ fwts_passed(fw, "%s returned an integer "
+ "0x%8.8" PRIx64 " (EISA ID %s).",
+ name, (uint64_t)obj->Integer.Value, tmp);
+ else
+ fwts_failed(fw, LOG_LEVEL_MEDIUM,
+ "MethodHIDInvalidInteger",
+ "%s returned a integer 0x%8.8" PRIx64 " "
+ "(EISA ID %s) but this is not a valid "
+ "EISA ID encoded PNP ID.",
+ name, (uint64_t)obj->Integer.Value, tmp);
+ break;
+ default:
+ fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_HIDBadReturnType",
+ "%s did not return a string or an integer.", name);
+ break;
+ }
+}
+
+static int method_test_HID(fwts_framework *fw)
+{
+ return fwts_evaluate_method(fw, METHOD_MANDATORY, &device,
+ "_HID", NULL, 0, method_test_HID_return, NULL);
+}
+
+static void method_test_GPE_return(
+ fwts_framework *fw,
+ char *name,
+ ACPI_BUFFER *buf,
+ ACPI_OBJECT *obj,
+ void *private)
+{
+ FWTS_UNUSED(private);
+ FWTS_UNUSED(buf);
+ bool failed = false;
+
+ switch (obj->Type) {
+ case ACPI_TYPE_INTEGER:
+ if (obj->Integer.Value <= 255)
+ fwts_passed(fw, "%s returned an integer 0x%8.8" PRIx64,
+ name, (uint64_t)obj->Integer.Value);
+ else
+ fwts_failed(fw, LOG_LEVEL_CRITICAL,
+ "MethodGPEBadInteger",
+ "%s returned an invalid integer 0x%8.8" PRIx64,
+ name, (uint64_t)obj->Integer.Value);
+ break;
+ case ACPI_TYPE_PACKAGE:
+ if (obj->Package.Elements[0].Type != ACPI_TYPE_LOCAL_REFERENCE) {
+ failed = true;
+ fwts_failed(fw, LOG_LEVEL_CRITICAL, "MethodGPEBadPackage",
+ "%s sub-package element 0 is not a reference.", name);
+ }
+
+ if (obj->Package.Elements[1].Type != ACPI_TYPE_INTEGER) {
+ failed = true;
+ fwts_failed(fw, LOG_LEVEL_CRITICAL, "MethodGPEBadPackage",
+ "%s sub-package element 1 is not an integer.", name);
+ }
+
+ if (!failed)
+ fwts_method_passed_sane(fw, name, "package");
+
+ break;
+ default:
+ fwts_failed(fw, LOG_LEVEL_CRITICAL, "MethodGPEBadReturnType",
+ "%s did not return an integer or a package.", name);
+ break;
+ }
+}
+
+static int method_test_GPE(fwts_framework *fw)
+{
+ return fwts_evaluate_method(fw, METHOD_MANDATORY, &device,
+ "_GPE", NULL, 0, method_test_GPE_return, "_GPE");
+}
+
+static void method_test_CRS_return(
+ fwts_framework *fw,
+ char *name,
+ ACPI_BUFFER *buf,
+ ACPI_OBJECT *obj,
+ void *private)
+{
+ uint8_t *data;
+ bool passed = true;
+ const char *tag = "Unknown";
+ char *objname = (char*)private;
+ char tmp[128];
+
+ FWTS_UNUSED(private);
+
+ if (fwts_method_check_type(fw, name, buf, ACPI_TYPE_BUFFER) != FWTS_OK)
+ return;
+ if (obj->Buffer.Pointer == NULL) {
+ snprintf(tmp, sizeof(tmp), "Method%sNullBuffer", objname);
+ fwts_failed(fw, LOG_LEVEL_CRITICAL, tmp,
+ "%s returned a NULL buffer pointer.", name);
+ return;
+ }
+ if (obj->Buffer.Length < 1) {
+ snprintf(tmp, sizeof(tmp), "Method%sBufferTooSmall", objname);
+ fwts_failed(fw, LOG_LEVEL_CRITICAL, tmp,
+ "%s should return a buffer of at least one byte in length.", name);
+ return;
+ }
+
+ data = (uint8_t*)obj->Buffer.Pointer;
+
+ if (data[0] & 128)
+ fwts_method_test_CRS_large_resource_items(fw, name, objname, data, obj->Buffer.Length, &passed, &tag);
+ else
+ fwts_method_test_CRS_small_resource_items(fw, name, objname, data, obj->Buffer.Length, &passed, &tag);
+
+ if (passed)
+ fwts_passed(fw, "%s (%s) looks sane.", name, tag);
+}
+
+static int method_test_CRS(fwts_framework *fw)
+{
+ return fwts_evaluate_method(fw, METHOD_MANDATORY, &device,
+ "_CRS", NULL, 0, method_test_CRS_return, NULL);
+}
+
+static fwts_framework_minor_test acpi_ec_tests[] = {
+ { method_test_CRS, "Test _CRS (Current Resource Settings)." },
+ { method_test_HID, "Test _HID (Hardware ID)." },
+ { method_test_GPE, "Test _GPE (General Purpose Events)." },
+ { NULL, NULL }
+};
+
+static int acpi_ec_deinit(fwts_framework *fw)
+{
+ FWTS_UNUSED(fw);
+ fwts_acpica_deinit();
+
+ return FWTS_OK;
+}
+
+static fwts_framework_ops acpi_ec_ops = {
+ .description = "ACPI embedded controller device test",
+ .init = acpi_ec_init,
+ .deinit = acpi_ec_deinit,
+ .minor_tests = acpi_ec_tests
+};
+
+FWTS_REGISTER("acpi_ec", &acpi_ec_ops, FWTS_TEST_ANYTIME, FWTS_FLAG_BATCH | FWTS_FLAG_TEST_ACPI)
+
+#endif
--
2.7.4
More information about the fwts-devel
mailing list