ACK: [PATCH V2 1/2] dmi: dmicheck: Fix Base Address Modifier checking

[Alex Hung]

On 2017-09-15 12:25 PM, Jeffrey Hugo wrote:
> The SMBIOS spec states that the Base Address Modifier field for a type 38
> structure is unused for SSIF, and contains the value 0.  The validation
> check of this field only accepts values 1 and 2, which are for other
> usecases.  Fix the check to allow value 0 for SSIF.
> 
> Signed-off-by: Jeffrey Hugo <jhugo at codeaurora.org>
> ---
>   src/dmi/dmicheck/dmicheck.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 61c6b81..2e139ad 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1772,7 +1772,7 @@ static void dmicheck_entry(fwts_framework *fw,
>   
>   			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 2, 2);
>   			dmi_reserved_bits_check(fw, table, addr, "Base Addr Modifier/Interrupt Info", hdr, sizeof(uint8_t), 0x10, 5, 5);
> -			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x1, 0x2, 6, 0x3);
> +			dmi_min_max_mask_uint8_check(fw, table, addr, "Base Addr Modifier/Interrupt Info)", hdr, 0x10, 0x0, 0x2, 6, 0x3);
>   			break;
>   
>   		case 39: /* 7.40 */
> 

Acked-by: Alex Hung <alex.hung at canonical.com>