NACK: [PATCH] acpica/fwts_acpica: disable module level code

[Alex Hung]

On 2018-05-28 08:09 PM, Alex Hung wrote:
> Module level code enables objects and methods inside if-statement;
> however, it causes problems to acpica emulator because any errors
> prevent DSDT or SSDT from being loaded. It is a good idea to disable
> module level code before any solutions are implemented by upstream.
> 
> Details are available @ https://bugs.acpica.org/show_bug.cgi?id=1444
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index 89beecc..930b3a3 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1057,7 +1057,8 @@ int fwts_acpica_init(fwts_framework *fw)
>   		FWTS_ACPICA_MODE(fw, FWTS_ACPICA_MODE_IGNORE_ERRORS);
>   	AcpiGbl_DisableAutoRepair =
>   		FWTS_ACPICA_MODE(fw, FWTS_ACPICA_MODE_DISABLE_AUTO_REPAIR);
> -	AcpiGbl_GroupModuleLevelCode = FALSE;
> +	AcpiGbl_GroupModuleLevelCode = TRUE;
> +	AcpiGbl_ExecuteTablesAsMethods = FALSE;
>   	AcpiGbl_CstyleDisassembly = FALSE;
>   
>   	pthread_mutex_init(&mutex_lock_sem_table, NULL);
> 

The fix in new acpica is very promising, and disabling MLC is no longer 
needed.