ACK: [PATCH 15/20][V2] fwts_clog: add fwts_clog_scan_patterns

Colin Ian King colin.king at canonical.com
Fri Jun 29 16:13:50 UTC 2018


On 28/06/18 10:16, Marcello Sylvester Bauer wrote:
> Signed-off-by: Marcello Sylvester Bauer <info at marcellobauer.com>
> ---
>  src/lib/include/fwts_clog.h |  1 +
>  src/lib/src/fwts_clog.c     | 13 +++++++++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/src/lib/include/fwts_clog.h b/src/lib/include/fwts_clog.h
> index 4ef58cf1..89cfc350 100644
> --- a/src/lib/include/fwts_clog.h
> +++ b/src/lib/include/fwts_clog.h
> @@ -29,5 +29,6 @@ typedef void (*fwts_clog_scan_func)(fwts_framework *fw, char *line, int repeated
>  void       fwts_clog_free(fwts_list *list);
>  fwts_list *fwts_clog_read(void);
>  int        fwts_clog_scan(fwts_framework *fw, fwts_list *clog, fwts_clog_scan_func callback, fwts_clog_progress_func progress, void *private, int *errors);
> +void       fwts_clog_scan_patterns(fwts_framework *fw, char *line, int repeated, char *prevline, void *private, int *errors);
>  
>  #endif
> diff --git a/src/lib/src/fwts_clog.c b/src/lib/src/fwts_clog.c
> index cc72a4ca..7c3e4ef5 100644
> --- a/src/lib/src/fwts_clog.c
> +++ b/src/lib/src/fwts_clog.c
> @@ -58,3 +58,16 @@ int fwts_clog_scan(fwts_framework *fw,
>  {
>          return fwts_log_scan(fw, clog, scan_func, progress_func, private, match, false);
>  }
> +
> +void fwts_clog_scan_patterns(fwts_framework *fw,
> +        char *line,
> +        int  repeated,
> +        char *prevline,
> +        void *private,
> +        int *errors)
> +{
> +    static char *advice =
> +        "This is a bug picked up by coreboot, but as yet, the "
> +        "firmware test suite has no diagnostic advice for this particular problem.";
> +    fwts_log_scan_patterns(fw, line, repeated, prevline, private, errors, "coreboot", advice);
> +}
> 
Thanks!

Acked-by: Colin Ian King <colin.king at canonical.com>




More information about the fwts-devel mailing list