ACK: [PATCH] snapcraft: update confinement and plugs

Alex Hung alex.hung at canonical.com
Tue Nov 13 07:07:46 UTC 2018


On 2018-11-09 9:53 p.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Make confinement strict and add in the required plugs for the tool
> to work correctly.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  snapcraft.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 4ecc2037..8cd9768f 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -2,7 +2,7 @@ name: fwts
>  version: V18.09.00
>  summary: The Firmware Test Suite (FWTS)
>  description: This is a firmware test suite that performs sanity checks on system firmware. It is intended to identify BIOS and ACPI errors and if appropriate it will try to explain the errors and give advice to help workaround or fix firmware bugs.  It is primarily intended to be a Linux-centric firmware troubleshooting tool.
> -confinement: devmode
> +confinement: strict
>  
>  parts:
>      fwts:
> @@ -27,6 +27,7 @@ parts:
>              - libbsd-dev
>  apps:
>      fwts:
> +        plugs: [home, hardware-observe, io-ports-control, kernel-module-control, log-observe, system-observe ]
>          command: bin/fwts
>          environment:
>              LD_LIBRARY_PATH: $LD_LIBRARY_PATH:$SNAP/lib/fwts
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list