ACK: [PATCH] acpica: fix linker issues when building with ACPI disabled

Alex Hung alex.hung at canonical.com
Wed Oct 17 05:37:44 UTC 2018


On 2018-10-16 11:38 p.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Some toolchains hit linker issues with missing symbols when
> building with ACPI disabled.  Work around this by declaring
> these symbols even though they are never referenced.
> 
> Works around PPC REHL 7.6 build issue:
> 
> /root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
> `AcpiGbl_InitEntries'
> /root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
> `AcpiGbl_InitFileLineCount'
> 
> Fixes: 24f2f2bfbb8f ("ACPICA: Update to version 20180810")
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpica/fwts_acpica.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index 4ffe80fd..d0c6ed7c 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1373,5 +1373,7 @@ VOID_FUNC(MpSaveSerialInfo)
>   */
>  unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
>  unsigned char AcpiGbl_VerboseHandlers = FALSE;
> +void *AcpiGbl_InitEntries = NULL;
> +uint32_t AcpiGbl_InitFileLineCount = 0;
>  
>  #endif
> 



Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list