ACK: [PATCH 12/12] fwts-test: apicinstance: fix up incorrect hex values

ivanhu ivan.hu at canonical.com
Mon Sep 10 04:30:36 UTC 2018



On 09/06/2018 10:20 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Recent commit "acpi: apicinstance: use correct format specifiers"
> fixes the output format of hex value by printing the hex value and
> not a decimal value. Fix up the regression tests to reflect this
> fix.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  fwts-test/apicinstance-0001/apicinstance-0001.log | 4 ++--
>  fwts-test/apicinstance-0001/apicinstance-0002.log | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fwts-test/apicinstance-0001/apicinstance-0001.log b/fwts-test/apicinstance-0001/apicinstance-0001.log
> index bb8c28c2..ec278964 100644
> --- a/fwts-test/apicinstance-0001/apicinstance-0001.log
> +++ b/fwts-test/apicinstance-0001/apicinstance-0001.log
> @@ -1,8 +1,8 @@
>  apicinstance    apicinstance: Test for single instance of APIC/MADT table.
>  apicinstance    ----------------------------------------------------------
>  apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
> -apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
> -apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x104
> +apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
> +apicinstance    Found APIC/MADT table APIC @ bf6dff70, length 0x68
>  apicinstance     (and differs from first APIC/MADT table).
>  apicinstance    FAILED [HIGH] MultipleAPICMADT: Test 1, Found 2 APIC/MADT
>  apicinstance    tables, the kernel expects just one.
> diff --git a/fwts-test/apicinstance-0001/apicinstance-0002.log b/fwts-test/apicinstance-0001/apicinstance-0002.log
> index ff12adf7..5ce9c631 100644
> --- a/fwts-test/apicinstance-0001/apicinstance-0002.log
> +++ b/fwts-test/apicinstance-0001/apicinstance-0002.log
> @@ -1,7 +1,7 @@
>  apicinstance    apicinstance: Test for single instance of APIC/MADT table.
>  apicinstance    ----------------------------------------------------------
>  apicinstance    Test 1 of 1: Test for single instance of APIC/MADT table.
> -apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x104
> +apicinstance    Found APIC/MADT table APIC @ bf6dfcc6, length 0x68
>  apicinstance    PASSED: Test 1, Found 1 APIC/MADT table(s), as expected.
>  apicinstance    
>  apicinstance    ==========================================================
Acked-by: Ivan Hu <ivan.hu at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180910/ac3a3951/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20180910/ac3a3951/attachment.sig>


More information about the fwts-devel mailing list