ACK: [PATCH 04/14] fwts-test: update regression test for PDTT

Colin Ian King colin.king at canonical.com
Fri Feb 8 11:41:29 UTC 2019


On 08/02/2019 03:23, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  fwts-test/pdtt-0001/acpidump-0002.log |  4 ++--
>  fwts-test/pdtt-0001/pdtt-0002.log     | 10 +++++-----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/fwts-test/pdtt-0001/acpidump-0002.log b/fwts-test/pdtt-0001/acpidump-0002.log
> index f019d007..8feef05a 100644
> --- a/fwts-test/pdtt-0001/acpidump-0002.log
> +++ b/fwts-test/pdtt-0001/acpidump-0002.log
> @@ -26,6 +26,6 @@ FACP @ 0x00000000
>  PDTT @ 0x0000000000000000
>    0000: 50 44 54 54 34 00 00 00 01 d2 49 4e 54 45 4c 20  PDTT4.....INTEL 
>    0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c  Template....INTL
> -  0020: 29 09 17 20 04 01 02 03 2c 00 00 00 aa 05 bb 02  ).. ....,.......
> -  0030: cc 07 dd 08                                      ....
> +  0020: 29 09 17 20 04 01 02 03 2c 00 00 00 aa 09 bb 02  ).. ....,.......
> +  0030: cc 0a dd 08                                      ....
>  
> diff --git a/fwts-test/pdtt-0001/pdtt-0002.log b/fwts-test/pdtt-0001/pdtt-0002.log
> index 1f9e440a..c6bb2f06 100644
> --- a/fwts-test/pdtt-0001/pdtt-0002.log
> +++ b/fwts-test/pdtt-0001/pdtt-0002.log
> @@ -9,19 +9,19 @@ pdtt            FAILED [MEDIUM] PDTTReservedNonZero: Test 1, PDTT Reserved
>  pdtt            field must be zero, got 0x00030201 instead
>  pdtt              Platform Communication Channel IDs
>  pdtt                Sub channel ID:          0xaa
> -pdtt                Flags:                   0x05
> +pdtt                Flags:                   0x09
>  pdtt            FAILED [HIGH] PDTTReservedBitsNonZero: Test 1, PDTT Flags
> -pdtt            Bits [7..2] must be zero, got 0x05 instead
> +pdtt            Bits [7..3] must be zero, got 0x09 instead
>  pdtt                Sub channel ID:          0xbb
>  pdtt                Flags:                   0x02
>  pdtt                Sub channel ID:          0xcc
> -pdtt                Flags:                   0x07
> +pdtt                Flags:                   0x0a
>  pdtt            FAILED [HIGH] PDTTReservedBitsNonZero: Test 1, PDTT Flags
> -pdtt            Bits [7..2] must be zero, got 0x07 instead
> +pdtt            Bits [7..3] must be zero, got 0x0a instead
>  pdtt                Sub channel ID:          0xdd
>  pdtt                Flags:                   0x08
>  pdtt            FAILED [HIGH] PDTTReservedBitsNonZero: Test 1, PDTT Flags
> -pdtt            Bits [7..2] must be zero, got 0x08 instead
> +pdtt            Bits [7..3] must be zero, got 0x08 instead
>  pdtt            
>  pdtt            
>  pdtt            ==========================================================
> 
Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list