[PATCH 06/10] cpu/msr: update THERM_INTERRUPT MSR masks

ivanhu ivan.hu at canonical.com
Wed Jul 24 07:02:07 UTC 2019



On 7/12/19 1:46 AM, Alex Hung wrote:
> BIT definition is as below:
> 
> 0	High-Temperature Interrupt Enable
> 1	Low-Temperature Interrupt Enable
> 2	PROCHOT# Interrupt Enable
> 3	FORCEPR# Interrupt Enable
> 4	Critical Temperature Interrupt Enable
> 7:5	Reserved
> 14:8	Threshold #1 Value
> 15	Threshold #1 Interrupt Enable
> 22:16	Threshold #2 Value
> 23	Threshold #2 Interrupt Enable
> 24	Power Limit Notification Enable
> 63:25	Reserved
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>   src/cpu/msr/msr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c
> index 6e28bc1c..3ff32c95 100644
> --- a/src/cpu/msr/msr.c
> +++ b/src/cpu/msr/msr.c
> @@ -361,7 +361,7 @@ static const msr_info IA32_MSRs[] = {
>   	{ "MCG_STATUS",			0x0000017a,	0xffffffffffffffffULL, NULL },
>   	{ "MCG_CTL",			0x0000017b,	0xffffffffffffffffULL, NULL },
>   	{ "CLOCK_MODULATION",		0x0000019a,	0x000000000000001fULL, NULL },
> -	{ "THERM_INTERRUPT",		0x0000019b,	0x000000000180801fULL, NULL },
> +	{ "THERM_INTERRUPT",		0x0000019b,	0x000000001ffff1ffULL, NULL },
Should be
{ "THERM_INTERRUPT",		0x0000019b,	0x0000000001ffff1fULL, NULL }, ?

Ivan

>   	//{ "THERM_STATUS",		0x0000019c,	0x0000000080000fffULL, NULL },
>   	{ "MISC_ENABLE",		0x000001a0,	0x0000000400c51889ULL, NULL },
>   	{ "PACKAGE_THERM_INTERRUPT",	0x000001b2,	0x0000000001ffff17ULL, NULL },
> 



More information about the fwts-devel mailing list