[PATCH] apic: apicedge: remove irq < 16 is edge only

Alex Hung alex.hung at canonical.com
Wed Jun 5 18:09:14 UTC 2019


The original legacy PIC 8259 supports edge-trigger only but later 8259A
supports both edge- and level-trigger. This limitation, of course, no
longer exists today.

Buglink: https://bugs.launchpad.net/bugs/1831035

Signed-off-by: Alex Hung <alex.hung at canonical.com>
---
 src/apic/apicedge/apicedge.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/apic/apicedge/apicedge.c b/src/apic/apicedge/apicedge.c
index 9f90fc5c..4abf011b 100644
--- a/src/apic/apicedge/apicedge.c
+++ b/src/apic/apicedge/apicedge.c
@@ -37,7 +37,7 @@
 /*
  * This test sanity checks apic irq information
  * rule of thumb:
- *   interrupts <16 should be EDGE
+ *   interrupts <16 should be EDGE or LEVEL
  *   interrupts >16 should be LEVEL
  *   acpi interrupt should be LEVEL
  */
@@ -86,10 +86,7 @@ static int apicedge_test1(fwts_framework *fw)
 					"ACPI Interrupt is incorrectly edge triggered.");
 			continue;
 		}
-		if ((irq < 15) && (edge == NOT_EDGE))
-			fwts_failed(fw, LOG_LEVEL_MEDIUM,
-				"LegacyIRQLevelTrig",
-				"Legacy interrupt %i is incorrectly level triggered.", irq);
+
 		if ((irq < 15) && (edge == UNDEFINED))
 			fwts_failed(fw, LOG_LEVEL_MEDIUM,
 				"NonLegacyIRQLevelTrig",
-- 
2.17.1




More information about the fwts-devel mailing list