[PATCH] acpi: s3: check for null pointer

Colin King colin.king at canonical.com
Mon Jun 10 10:57:21 UTC 2019


From: Colin Ian King <colin.king at canonical.com>

The pointer 'klog_diff' can potentially be null, so check for this.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/s3/s3.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
index 79df1a6c..c754af81 100644
--- a/src/acpi/s3/s3.c
+++ b/src/acpi/s3/s3.c
@@ -551,8 +551,9 @@ static int s3_test_multiple(fwts_framework *fw)
 
 		fwts_progress_message(fw, percent, "(Checking logs for errors)");
 		klog_diff = fwts_klog_find_changes(klog_pre, klog_post);
-		s3_check_log(fw, klog_diff, &klog_errors, &klog_oopses, &klog_warn_ons,
-			&suspend_too_long, &resume_too_long);
+		if (klog_diff)
+			s3_check_log(fw, klog_diff, &klog_errors, &klog_oopses, &klog_warn_ons,
+				&suspend_too_long, &resume_too_long);
 
 		fwts_klog_free(klog_pre);
 		fwts_klog_free(klog_post);
-- 
2.20.1




More information about the fwts-devel mailing list