ACK: [PATCH] acpi: dscdump: reduce scope of loop counter i

Alex Hung alex.hung at canonical.com
Tue Jun 11 16:31:20 UTC 2019


On 2019-06-11 2:05 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Clean up a cppcheck style check.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/dsddump/dsddump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/dsddump/dsddump.c b/src/acpi/dsddump/dsddump.c
> index 1e3c26c1..c4e0610b 100644
> --- a/src/acpi/dsddump/dsddump.c
> +++ b/src/acpi/dsddump/dsddump.c
> @@ -144,7 +144,6 @@ static int dsddump_test1(fwts_framework *fw)
>  			ACPI_OBJECT_LIST arg_list;
>  			ACPI_OBJECT *obj;
>  			ACPI_BUFFER buf;
> -			uint32_t i;
>  			int ret;
>  
>  			arg_list.Count   = 0;
> @@ -161,6 +160,7 @@ static int dsddump_test1(fwts_framework *fw)
>  			    (obj->Package.Elements[0].Type == ACPI_TYPE_BUFFER) &&
>  			    (obj->Package.Elements[0].Buffer.Pointer != NULL) &&
>  			    (obj->Package.Elements[0].Buffer.Length == 16)) {
> +				uint32_t i;
>  
>  				fwts_log_info_verbatim(fw, "Name: %s", name);
>  				for (i = 0; i < obj->Package.Count; i += 2)
> 




Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list