ACK: [PATCH] dmicheck: add dmi version check to SMBIOS3

ivanhu ivan.hu at canonical.com
Mon Dec 14 03:42:50 UTC 2020



On 12/10/20 7:45 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index aa31e936..41dd0f6c 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -2230,6 +2230,9 @@ static int dmicheck_test3(fwts_framework *fw)
>  		return FWTS_ERROR;
>  	}
>  
> +	if (dmi_version_check(fw, version) != FWTS_OK)
> +		return FWTS_SKIP;
> +
>  	table = dmi_table_smbios30(fw, &entry30);
>  	if (table == NULL)
>  		return FWTS_ERROR;
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list