ACK: [PATCH 1/2] fwts_framework: skip sbbr & ebbr on non-aarch64 systems

Colin Ian King colin.king at canonical.com
Wed Feb 10 19:52:02 UTC 2021


On 10/02/2021 19:48, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1915210
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/lib/src/fwts_framework.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 593c4171..21737879 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -1337,8 +1337,13 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>  				return FWTS_ERROR;
>  			break;
>  		case 46: /* --sbbr */
> +#if defined(FWTS_ARCH_AARCH64)
>  			fw->flags |= FWTS_FLAG_TEST_SBBR;
>  			break;
> +#else
> +			fprintf(stderr, "option not available on this architecture\n");
> +			return FWTS_ERROR;
> +#endif
>  		case 47: /* --ifv */
>  			fw->flags |= FWTS_FLAG_FIRMWARE_VENDOR;
>  			break;
> @@ -1346,8 +1351,13 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>  			fwts_framework_strdup(&fw->clog, optarg);
>  			break;
>  		case 49: /* --ebbr */
> +#if defined(FWTS_ARCH_AARCH64)
>  			fw->flags |= FWTS_FLAG_TEST_EBBR;
>  			break;
> +#else
> +			fprintf(stderr, "option not available on this architecture\n");
> +			return FWTS_ERROR;
> +#endif
>  		case 50: /* --dump-acpi-from-sysfs */
>  			fw->flags |= FWTS_FLAG_DUMP_ACPI_FROM_SYSFS;
>  			break;
> 

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the fwts-devel mailing list