[PATCH v2] acpi: method: Make method_test_ADR() optional.

Grzegorz Bernacki gjb at semihalf.com
Wed Jun 30 05:45:43 UTC 2021


According to ACPI specification _ADR is not required
if _HID exists for given device. This test focus on
testing returning value of _ADR, not the existence of
_ADR, that's why it should not be mandatory.

BugLink: https://bugs.launchpad.net/fwts/+bug/1933493

Signed-off-by: Grzegorz Bernacki <gjb at semihalf.com>
---
 src/acpi/method/method.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 9832c4e1..9200f7d4 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -4340,12 +4340,8 @@ static int method_test_VPO(fwts_framework *fw)
 
 static int method_test_ADR(fwts_framework *fw)
 {
-	if (fw->flags & FWTS_FLAG_SBBR)
-		return method_evaluate_method(fw, METHOD_MANDATORY,
-			"_ADR", NULL, 0, fwts_method_test_integer_return, NULL);
-	else
-		return method_evaluate_method(fw, METHOD_OPTIONAL,
-			"_ADR", NULL, 0, fwts_method_test_integer_return, NULL);
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_ADR", NULL, 0, fwts_method_test_integer_return, NULL);
 }
 
 static void method_test_BCL_return(
-- 
2.25.1




More information about the fwts-devel mailing list