[PATCH 1/1] lib: Solve issue of loading SMBIOS table

[G Edhaya Chandran]

Hi Alex,

  Thank you for the reply. I have raised a new issue with the patch is attached:
Bug #1947956 “SMBIOS table loading fails from smbios_entry_point...” : Bugs : Firmware Test Suite (launchpad.net)<https://bugs.launchpad.net/fwts/+bug/1947956>

Yes, this is different from issue raised by Sunny, we which we have no solution as yet.
https://bugs.launchpad.net/bugs/1947786

I have now subscribed fwts-devel (https://lists.ubuntu.com/mailman/listinfo/fwts-devel), however I did not get any confirmation email.
So I believe my subscription is still not through.

With Warm Regards,
Edhay

From: Sunny Wang <Sunny.Wang at arm.com>
Sent: 21 October 2021 01:18
To: Alex Hung <alex.hung at canonical.com>
Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com>; fwts-devel at lists.ubuntu.com; colin.king at canonical.com; ivan.hu at canonical.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>; Paul Yang <Paul.Yang at arm.com>; Sunny Wang <Sunny.Wang at arm.com>
Subject: RE: [PATCH 1/1] lib: Solve issue of loading SMBIOS table

Hi Alex,
Sorry for the confusion. This patch is going to fix a different issue.
The symptom of this issue is the dmicheck failures. We didn’t report a bug for this issue because Edhaya already has a fix.
The symptom of the https://bugs.launchpad.net/bugs/1947786 is that the testing stops at dmicheck test. We haven’t completely root caused this issue yet, so I reported this bug for getting help from other FWTS experts.

Hi Edhaya,
Have you subscribed fwts-devel (https://lists.ubuntu.com/mailman/listinfo/fwts-devel)? If not, this may be the reason why your patch doesn’t go to Alex.  Sorry for that I forgot to mention this in our offline discussion.

Best Regards,
Sunny
From: Alex Hung <alex.hung at canonical.com<mailto:alex.hung at canonical.com>>
Sent: 20 October 2021 19:42
To: Sunny Wang <Sunny.Wang at arm.com<mailto:Sunny.Wang at arm.com>>
Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com<mailto:Edhaya.Chandran at arm.com>>; fwts-devel at lists.ubuntu.com<mailto:fwts-devel at lists.ubuntu.com>; colin.king at canonical.com<mailto:colin.king at canonical.com>; ivan.hu at canonical.com<mailto:ivan.hu at canonical.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com<mailto:Samer.El-Haj-Mahmoud at arm.com>>; Paul Yang <Paul.Yang at arm.com<mailto:Paul.Yang at arm.com>>
Subject: Re: [PATCH 1/1] lib: Solve issue of loading SMBIOS table

Hi Sunny,

Thanks for reporting and testing the patch.

Hi Edhaya,

Thanks for submitting patches; however, the patch did not go through. Ex, I couldn't find it @ https://lists.ubuntu.com/archives/fwts-devel/2021-October/thread.html or https://patchwork.ozlabs.org/project/fwts/list/, andI did not receive it myself.

Could you please send it again?

While you are at it, please add "Buglink: https://bugs.launchpad.net/bugs/1947786" to the patch description.

Cheers,
Alex Hung

On Wed, Oct 20, 2021 at 10:02 AM Sunny Wang <Sunny.Wang at arm.com<mailto:Sunny.Wang at arm.com>> wrote:
Tested on an ARM based server system. Thanks for fixing this, Edhaya.

Tested-by: Sunny Wang <sunny.wang at arm.com<mailto:sunny.wang at arm.com>>

-----Original Message-----
From: G Edhaya Chandran <edhaya.chandran at arm.com<mailto:edhaya.chandran at arm.com>>
Sent: 20 October 2021 15:30
To: fwts-devel at lists.ubuntu.com<mailto:fwts-devel at lists.ubuntu.com>
Cc: colin.king at canonical.com<mailto:colin.king at canonical.com>; ivan.hu at canonical.com<mailto:ivan.hu at canonical.com>; alex.hung at canonical.com<mailto:alex.hung at canonical.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com<mailto:Samer.El-Haj-Mahmoud at arm.com>>; G Edhaya Chandran <Edhaya.Chandran at arm.com<mailto:Edhaya.Chandran at arm.com>>; Sunny Wang <Sunny.Wang at arm.com<mailto:Sunny.Wang at arm.com>>; Paul Yang <Paul.Yang at arm.com<mailto:Paul.Yang at arm.com>>
Subject: [PATCH 1/1] lib: Solve issue of loading SMBIOS table

In the case where SMBIOS table is loaded from
/sys/firmware/dmi/tables/smbios_entry_point,
the load fails due to a logical error in the if condition which is
solved below
The load fails with the below logs
dmicheck: Could not find any SMBIOS Table Entry Points.
dmicheck: Cannot find SMBIOS30 table entry.

The issue may have been introduced during the recent refactoring of the
code.

Signed-off-by: Edhaya Chandran <edhaya.chandran at arm.com<mailto:edhaya.chandran at arm.com>>

---
 src/lib/src/fwts_smbios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/src/fwts_smbios.c b/src/lib/src/fwts_smbios.c
index 8da572e9..6402fad8 100644
--- a/src/lib/src/fwts_smbios.c
+++ b/src/lib/src/fwts_smbios.c
@@ -91,7 +91,7 @@ static void *fwts_smbios_find_entry_uefi(
                }

                if (fwts_load_file("/sys/firmware/dmi/tables/smbios_entry_point", entry, size) == FWTS_OK &&
-                   strncmp((char*)entry, sm, strlen(sm))) {
+                   !strncmp((char*)entry, sm, strlen(sm))) {
                        fwts_log_info(fw, "%s entry loaded from /sys/firmware/dmi/tables/smbios_entry_point\n", smbios);
                        *type  = FWTS_SMBIOS;
                        return addr;
--
2.17.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


--
Cheers,
Alex Hung
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20211021/49651a50/attachment-0001.html>