[Bug 1992516] Re: Missing WMI GUID for Intel WFDE

[ivanhu]

Bryan,

On 11/23/22 00:27, Kemp, Bryan wrote:
> Ivan,
> I understand your logic and I do agree with the general idea. However, let me try to put the question in a different way, and see if we end up at the same place.
> 
> Is it a firmware issue, that the linux kernel doesn’t have a driver for a particular well known guid? My view point is that it is not a failure.

That's why FWTS has the severity levels(Critical, High, Medium, Low) 
instead of all using warnings.

> 
> My suggestion would be to allow a list of known GUIDs such as the one could be added to a table so that it could not be flagged as an issue or at the very least have a lower severity level. I am not recommending to blindly ignore all unknown GUIDs.

Currently the failure is Medium, not critical or high. We think it fits 
this issue severity level.
FAILED [MEDIUM] WMIUnknownGUID: Test 1, GUID

And maybe we can add a wishlist for future implement to allow users 
ignore some GUIDs.
https://bugs.launchpad.net/fwts/+bug/1997508

Cheers,
Ivan

> 
> 
> --Bryan
> 
> -----Original Message-----
> From: ivanhu <ivan.hu at canonical.com>
> Sent: Monday, November 21, 2022 10:11 PM
> To: Kemp, Bryan <Bryan_Kemp at Dell.com>
> Cc: Ho, Hung <Hung_Ho at Dell.com>; fwts-devel at lists.ubuntu.com
> Subject: Re: [Bug 1992516] Re: Missing WMI GUID for Intel WFDE
> 
> 
> [EXTERNAL EMAIL]
> 
> Hi Bryan,
> 
> I understand most of you like to have no failures on your firmware implementation, but it is not the goal of the FWTS implementation. FWTS aims to find out all the potential issues of the firmware implementation, and then they can be reviewed by the firmware experts.
> Like this GUID issue, after you reviewed it, you confirmed it is only used by Windows, no impact to Linux. But if FWTS won't mark it as failure, we can not assure the next GUID which has no handle in kernel driver will also no impact without being reviewed.
> FWTS is implemented base on the Linux and not test under Windows, maybe under windows will no such failures but you cannot guarantee if users will use it to install Linux or not. That's why FWTS would like to find out all the potential issues with severity level.
> 
> 
> Cheers,
> Ivan
> 
> On 11/1/22 22:28, Kemp, Bryan wrote:
>> Ok, I think I understand. My apologies as I am just coming up to speed on this. I am curious if this is an exception case that needs to be included / understood by the toolset. As I understand it, the GUID is built into the BIOS firmware. I currently believe its purpose is for Windows and is not required for Linux, but must be in the firmware either way. That is why there is no kernel driver for the GUID. Should this be a failure?  I would assume that if this tool ran under Windows, then there would be the proper support for this GUID and the test would be successful. My goal is to be able to clean up some false negatives or at a minimum reduce the severity. Does this make sense?
>>
>>
>> --Bryan
>>
>> -----Original Message-----
>> From: noreply at launchpad.net <noreply at launchpad.net> On Behalf Of Ivan
>> Hu
>> Sent: Tuesday, November 1, 2022 1:46 AM
>> To: Kemp, Bryan <Bryan_Kemp at Dell.com>
>> Subject: [Bug 1992516] Re: Missing WMI GUID for Intel WFDE
>>
>>
>> [EXTERNAL EMAIL]
>>
>> It is still no kernel driver handle this GUID, i.e. it is still unknown to the kernel, a driver may need to be implemented for this GUID. So we won't apply this patch until it exists in kernel.
>>
>> ** Changed in: fwts
>>          Status: In Progress => Won't Fix
>>
>> --
>> You received this bug notification because you are subscribed to the bug report.
>> https://urldefense.com/v3/__https://bugs.launchpad.net/bugs/1992516__;
>> !!LpKI!jrb0jJz-4qdiYOgCyTWnl20OVrSx7mHPJjJ-B1U_QN2Vwf05NY_u52R52_gSB_M
>> qqCf2LX9msII0PFKKLXJ1oHQ$  [bugs[.]launchpad[.]net]
>>
>> Title:
>>     Missing WMI GUID for Intel WFDE
>>
>> Status in Firmware Test Suite:
>>     Won't Fix
>>
>> Bug description:
>>     This test fails and the error indicates the GUID needs to be added to
>>     the list of known good GUIDs
>>
>>     \_SB_.WFDE._WDG (2 of 3)
>>       GUID: A6FEA33E-DABF-46F5-BFC8-460D961BEC9F
>>       WMI Event:
>>         Flags          : 0x08 (Event)
>>         Notification ID: 0xd0
>>         Reserved       : 0x00
>>         Instance       : 0x01
>>     FAILED [MEDIUM] WMIUnknownGUID: Test 1, GUID
>>     A6FEA33E-DABF-46F5-BFC8-460D961BEC9F is unknown to the kernel, a driver may need
>>     to be implemented for this GUID.
>>
>> To manage notifications about this bug go to:
>> https://urldefense.com/v3/__https://bugs.launchpad.net/fwts/*bug/19925
>> 16/*subscriptions__;Kys!!LpKI!jrb0jJz-4qdiYOgCyTWnl20OVrSx7mHPJjJ-B1U_
>> QN2Vwf05NY_u52R52_gSB_MqqCf2LX9msII0PFKKJGVElnc$
>> [bugs[.]launchpad[.]net]
>>
>>
>> Internal Use - Confidential
> 
> Internal Use - Confidential