[PATCH] dmicheck: fix the wrong slot height value range

Ivan Hu ivan.hu at canonical.com
Tue Mar 7 07:47:43 UTC 2023


Base on the SMBIOS specification, 7.10.13 System Slots — Slot Height
the slot height value should be 0 to 4

Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index 9717d802..497a5c5f 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1505,7 +1505,7 @@ static void dmicheck_entry(fwts_framework *fw,
 			if (hdr->length < (0x18 + 5 * data[0x12]))
 				break;
 
-			dmi_min_max_uint8_check(fw, table, addr, "Slot Height", hdr, (0x17 + 5 * data[0x12]), 0, 0x6);
+			dmi_min_max_uint8_check(fw, table, addr, "Slot Height", hdr, (0x17 + 5 * data[0x12]), 0, 0x4);
 
 			break;
 
-- 
2.25.1




More information about the fwts-devel mailing list