eod report 20121203

[Gustavo Niemeyer]

On Wed, Dec 5, 2012 at 5:24 AM, David Cheney <david.cheney at canonical.com> wrote:
> Hi Gustavo
>
>> Have you checked out LiveTests.TestStartInstanceOnUnknownPlatform?
>> Could we do something along these lines for bootstrap?
>
> I tried to adapt that but I cannot find a way of testing the logic inside environs.StartInstance as that method does not take a version.Binary. Solutions involving changing the value of version.Current are possible, but have previously been rejected in prior CLs.

The change you're making is having Bootstrap respect DefaultSeries. If
DefaultSeries changes, the platform that Bootstrap looks for should
respect default-series. We need a test for that behavior, and that's
really all that there is to that issue. I don't understand why you
want to change version.Current when the thing that actually does
change is a configuration option that is trivial to change, and to be
honest I'm slightly surprised about how difficult testing this trivial
change seems to be, when we have the ability to change pretty much
anything.


gustavo @ http://niemeyer.net