Do we care about 1.16 compatibility for 'juju add-machine ssh:user at host" ?

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...
> 
> However, it actually doesn't really do what we want anyway. The
> code in question detects that we had an error after allocating a
> machineId, and then tries to clean up by calling DestroyMachine. It
> is fairly likely, though, that the machine agent will never
> actually come up.
> 
> 
> I don't follow. If there's no machine id, there's no machine, and
> no need to destroy it.
> 
> It seems like a lot of busy work to end up with a machine that is
> in a bad state.
> 
> 
> So, do we (1) figure out what to run (series, arch) and whether
> it's possible; (2) add that machine to state; (3) start the agent
> on the machine?
> 
> If (2) fails, we shouldn't have changed the machine; and if (3)
> fails I agree we need a fast path to just nuke the machine in
> state, but it's surely not going to leave the actual system in a
> confused state, is it?

When I tried it, I ended up with

 "1":
   agent-state: pending
...
   life: dying

Which doesn't look like its ever going to resolve.

Anyway, you sound very strongly in favor of moving all the code around
to support this, so I'll keep pushing on it.


> 
> 4) Client.MachineConfig didn't exist in 1.16. This is probably the 
> biggest deal. The API actually does a lot of work. It grabs the
> API and State addresses, looks up tools for the machine (in the
> provider), and sets up a new Machine ID + Password combination for
> the agent.
> 
> The big thing is having to reproduce all that chunk of code seems
> like a PITA and searching for tools from the client is annoying to
> do again.
> 
> 
> I'm willing to pay an additional tools lookup to keep manual 
> provisioning in sync with everything else; and ISTM that this is 
> otherwise just a matter of moving that code temporarily to a
> shared location (like statecmd), and then putting it back into the
> api server directly when we don't need direct db access any more.
> Am I missing something?
> 
> Cheers William


John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlKlNJoACgkQJdeBCYSNAAN37wCgqfMEiopC07z2yRorbNTXrYJg
cEoAni1j/qhhxt836Iya8MxJjQijFG2y
=IIUI
-----END PGP SIGNATURE-----