Storage vs. PublicStorage

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

> If an error occurs when checking a bucket, it moves on to the next
> in the list.
> 
> The Openstack provider doesn't return nil, but does return
> environs.EmptyStorage if no public bucket is specified (sorry, I
> misremembered). A quick read of the code seems to indicate that nil
> should have worked also, but clearly not if you got an error. So
> try returning environs.EmptyStorage in your provider's 
> PublicStorage() method and see if findMongo still errors.
> 
> 

StorageReader is an interface. And we are calling:

url, err := findMongo(env.Storage(), vers)
and inside that we have:

names, err := store.List(path)

So either we should:

a) teach findMongo to do:
  if store == nil { return "", fmt.Errorf(????)}

b) change MongoURL to check if env.Storage() is nil

c) Change the API so that env.Storage() must return EmptyStorage [add
a cross-environ test case for it]

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlE+yI4ACgkQJdeBCYSNAAO60gCfc3JiYHvZxsHRrpzRhV490Z7Y
p+YAnRNv0a4rL06cDiPxPFD+YsAuFd6V
=yIFG
-----END PGP SIGNATURE-----