Label: Ready For Review

[Jonathan Aquilina]

On 2014-08-12 00:30, Nate Finch wrote:
> Hmm, thats a good point.  This whole "only owners can label stuff" is
> annoying.
>
> I wonder if we should just make everyone owners.
> On Aug 11, 2014 5:59 PM, "David Cheney" <david.cheney at canonical.com
> [9]> wrote:
>
>> What if the review needs the author to rework ?
>>
>> On Tue, Aug 12, 2014 at 7:55 AM, Nate Finch
>> <nate.finch at canonical.com [1]> wrote:
>> > Merge it and itll get closed and out of the list of open PRs.  I
>> presume
>> > the submitter is paying enough attention to merge their own
>> stuff.
>> >
>> > On Aug 11, 2014 5:44 PM, "David Cheney"
>> <david.cheney at canonical.com [2]> wrote:
>> >>
>> >> How can we remove the label once the review has been done ?
>> >>
>> >> On Tue, Aug 12, 2014 at 4:33 AM, Nate Finch
>> <nate.finch at canonical.com [3]>
>> >> wrote:
>> >> > I made a label on github.com/juju/juju [4] (and coincidentally
>> >> > github.com/juju/utils [5]) called Ready For Review. The reason
>> for the label
>> >> > is
>> >> > that it is often difficult to figure out what branches are
>> actually
>> >> > ready to
>> >> > be reviewed and which ones are really WIP and therefore arent
>> waiting
>> >> > to be
>> >> > reviewed.  Its simple to filter by labels to see whats
>> assigned to
>> >> > Ready
>> >> > For Review, so the on-call reviewers (or anyone else) can find
>> stuff to
>> >> > review.
>> >> >
>> >> > I did this because some people had mentioned to me that they
>> had
>> >> > branches
>> >> > that were waiting for reviews, but no one was reviewing them.
>>  Pinging
>> >> > people who are online works, but its hard to ping people who
>> arent
>> >> > online.... so I figured this was easier and gives everyone
>> somewhere to
>> >> > go
>> >> > to find what PRs are languishing.
>> >> >
>> >> > I know we have the WIP: prefix for branches that arent ready
>> to be
>> >> > generally reviewed.... but thats opt-out, which means its easy
>> to
>> >> > forget
>> >> > to put that on your branch and have people think its ready for
>> review
>> >> > when
>> >> > its not....  which means people tend to err on the side of
>> just not
>> >> > reviewing stuff.  The Ready For Review label is opt-in, so
>> theres no
>> >> > doubt
>> >> > that the submitter thinks its ready.
>> >> >
>> >> > It currently requires someone on this list to add the label
>> (at least
>> >> > for
>> >> > github.com/juju/juju [6]), which is somewhat unfortunate, but
>> its really
>> >> > only
>> >> > needed if you think your code wont get reviewed otherwise...
>> and maybe
>> >> > just
>> >> > asking someone to add that label will encourage them to review
>> your
>> >> > code.
>> >> >
>> >> > -Nate
>> >> >
>> >> > --
>> >> > Juju-dev mailing list
>> >> > Juju-dev at lists.ubuntu.com [7]
>> >> > Modify settings or unsubscribe at:
>> >> > https://lists.ubuntu.com/mailman/listinfo/juju-dev [8]
>> >> >
>
>
> Links:
> ------
> [1] mailto:nate.finch at canonical.com
> [2] mailto:david.cheney at canonical.com
> [3] mailto:nate.finch at canonical.com
> [4] http://github.com/juju/juju
> [5] http://github.com/juju/utils
> [6] http://github.com/juju/juju
> [7] mailto:Juju-dev at lists.ubuntu.com
> [8] https://lists.ubuntu.com/mailman/listinfo/juju-dev
> [9] mailto:david.cheney at canonical.com

I know it is possible on the issue tracker to label things even pull 
requests. Not sure if that would be a good way too go or not?

-- 
Regards,
Jonathan Aquilina
Founder Eagle Eye T