review request

Nate Finch nate.finch at canonical.com
Thu Aug 28 19:59:46 UTC 2014


Roger was kind enough to review it.  If others would like to, that's great,
but it has at least had a good review by someone other than the author now
:)


On Thu, Aug 28, 2014 at 12:35 PM, Nate Finch <nate.finch at canonical.com>
wrote:

> I have a pull request <https://github.com/juju/juju/pull/512> for using
> Lumberjack <https://github.com/natefinch/lumberjack>, the log rolling
> package I wrote, but the package itself hasn't been reviewed itself.  I'd
> like to get it reviewed just like any other code we use in Juju.  It's
> fairly simple code, only about 400 lines, and no dependencies outside the
> package itself.
>
> -Nate
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140828/16d96e3f/attachment.html>


More information about the Juju-dev mailing list