reverting (fixing?) r2814
John Meinel
john at arbash-meinel.com
Sun Jun 1 10:05:27 UTC 2014
So I missed this when it was up for review, but I think the approach it
takes is actually incorrect.
The patch as it stands sorts the list that we supplied to put 'localhost'
addresses first. However, that interferes with the logic that we want to
put "the last one we successfully connected to" first.
Now, the fix *might* just be to use "sort.Stable" instead of just
"sort.Sort". As long as all the things that aren't "localhost" aren't
moved around, then we can keep the property that whatever you successfully
connected to last time, you'll try to use next time.
Also, it would see the tests as written aren't actually valid because
something named "localhost1" is not localhost. It should probably be
"localhost:1" if we want to use that syntax.
John
=:->
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140601/b48d6bf5/attachment.html>
More information about the Juju-dev
mailing list