Is it ok to Close PRs to indicate WiP?

[roger peppe]

On 17 June 2014 10:02, John Meinel <john at arbash-meinel.com> wrote:
> Also, I do think we want to follow our old Rietveld behavior, where for each
> comment a reviewer made, the submitter can respond (even if just with
> "Done"). I realize this generates a lot of email noise, but it means that
> any reviewer can come along and see what has been addressed and what hasn't.
> Or at least follow along with the conversation.

I agree entirely. This is even more important since github doesn't
make it possible to see what changes have been made in response
to a given comment.

> Thoughts? Is Closed to big of a hammer. Is there something else in our
> process that we need to focus on?

I think that only the person that created the pull request should close it,
unless it has been merged.

Unfortunately I can't think of a decent way of finding PRs that still
need review.
Perhaps someone could hack up a quick tool that pulls comments from
outstanding PRs and prints any PRs that don't have a "reviewed" comment.

http://godoc.org/github.com/google/go-github/github#PullRequestsService.ListComments