Please stop adding dependencies to the state package

David Cheney david.cheney at canonical.com
Thu Nov 13 23:05:00 UTC 2014


Hello,

Please stop adding dependencies to the state package.

The dependency tree for state must go

mgo <- state <- things that depend on state

At the moment state depends on things like backups, multiwatchers,
presence, toolstorage.

This is wrong.

Eric, i'm not picking on you here, it's just that b sorts first, and
this is the one I saw today. There are many other examples, including
the multiwatcher which also break this model

If you add functionality to state, then the code has to go ***INSIDE**
state, or be written to take a *state.State.

Please help me out by not adding more dependencies to state.

Thank you for your time

Dave



More information about the Juju-dev mailing list