Doing chained diffs w/ Reviewboard

Eric Snow eric.snow at canonical.com
Thu Sep 18 15:11:35 UTC 2014


On Thu, Sep 18, 2014 at 4:45 AM, Ian Booth <ian.booth at canonical.com> wrote:
> Eric, can we do something on the review board and/or github side to make this
> sort of thing easier? Implement a script which follows the Launchpad workflow or
> something?

Totally.  Writing it as a git plugin ("git-review" on $PATH -> "git
review" subcommand) should be pretty straight-forward since rbt
supports uploading a diff.  However, given that I'm trying to wrap up
backups work before the upcoming sprint I'm not sure I'll have time to
work on anything like that before then.  Regardless, since it's just a
matter of generating a diff and using rbt to upload it, I expect
anyone could write the script.

-eric

p.s. It is a shame that git does not have better support for a prereq
branch workflow.  I chain branches constantly.  Sounds like a job for
another git plugin. :)

p.p.s. Github support for chained branches is another matter entirely,
though I expect we could come up with a work-around for that too. :)



More information about the Juju-dev mailing list