Reviews for merges _from_ master to feature branches
Tim Penhey
tim.penhey at canonical.com
Tue Dec 1 01:15:43 UTC 2015
On 01/12/15 13:56, Ian Booth wrote:
>
>
> On 01/12/15 10:17, David Cheney wrote:
>> Hello,
>>
>> Why are reviewers being created for merges from master to feature
>> branches ? What purpose does this serve ?
>>
>
> They appear because you create a github PR which triggers a reviewboard review
> to be created. I just self approve and everything gets processed soon enough.
> You still want a PR to interface with the landing bot.
+1 I also just self approve merges from master into feature branches,
and I have told others that they can do the same.
No need to review merges of master into your own feature.
Makes it go through the bot, which I like. Also best practice to just
merge in a blessed revision.
Tim
More information about the Juju-dev
mailing list