Comprehensive reviews & when to do them?

Katherine Cox-Buday katherine.cox-buday at canonical.com
Mon Dec 14 15:39:25 UTC 2015


Hey All,

I think we have a mis-alignment in how we currently do reviews and 
feature branches.

We've switched over to feature-branches which is great and has allowed 
Moonstone to land "good enough" code into our feature branch to support 
a bi-weekly demo and solicit feedback. At the same time, I feel like 
we're wasting people's time asking for a +1 on code that is not intended 
to be landed into master. Often this code will take shortcuts or stub 
out some code, and as the lead I'll make a judgment call to circle-back 
later. Reviewers don't necessarily know this.

Conversely, when we go to land the feature branch into master, these PRs 
are generally rubber-stamped.

I feel like maybe we have this backwards?

-
Katherine



More information about the Juju-dev mailing list