master upgrade problems

[Tim Penhey]

Hi folks,

A branch I landed yesterday broke all the upgrade tests. This was a
branch that added a new login version.

Since 1.23 writes the environment UUID to the agent config, I had
wrongly assumed that it would all be good.

This has now been rectified with commit b56d0a30
(howbazaar/fix-legacy-upgrades), and has been verified locally.

However, upgrades are still failing CI, but none of the jobs have the
necessary log files attached.  Either the artifact list is empty, or the
log file is not complete. None of the failures since my branch has
landed have given any indication of what the problem is.

The old problem can be identified by the following sequence in
machine-0.log:


2015-03-19 14:44:26 DEBUG juju.apiserver utils.go:67 validate env uuid:
empty envUUID
2015-03-19 14:44:26 INFO juju.api apiclient.go:259 connection
established to "wss://localhost:17070/"
2015-03-19 14:44:26 DEBUG juju.apiserver apiserver.go:273 <- [6]
<unknown>
{"RequestId":1,"Type":"Admin","Version":2,"Request":"Login","Params":"'params
redacted'"}
2015-03-19 14:44:26 DEBUG juju.apiserver admin.go:147 hostPorts:
[[localhost:17070 10.0.0.243:17070 10.0.1.1:17070 192.168.122.1:17070
127.0.0.1:17070 [::1]:17070]]
2015-03-19 14:44:26 DEBUG juju.apiserver apiserver.go:287 -> [6]
machine-0 69.173389ms {"RequestId":1,"Response":"'body redacted'"}
Admin[""].Login
2015-03-19 14:44:26 DEBUG juju.apiserver apiserver.go:273 <- [6]
machine-0
{"RequestId":2,"Type":"Agent","Request":"GetEntities","Params":"'params
redacted'"}
2015-03-19 14:44:26 DEBUG juju.apiserver apiserver.go:287 -> [6]
machine-0 89.265us {"RequestId":2,"Error":"logged in to server, no
environment, \"Agent\" not supported","Response":"'body redacted'"}
Agent[""].GetEntities
2015-03-19 14:44:26 ERROR juju.worker runner.go:219 exited "api": logged
in to server, no environment, "Agent" not supported

The identifying marks are:

empty envUUID

No environment UUID, leading to a connection path at the root for the
websocket.

{"RequestId":1,"Type":"Admin","Version":2,"Request":"Login",...

Version 2 of the Login command, followed by this error:

logged in to server, no environment, "Agent" not supported

With the fix we see the following:

2015-03-20 00:38:13 DEBUG juju.apiserver utils.go:67 validate env uuid:
empty envUUID
2015-03-20 00:38:13 INFO juju.api apiclient.go:259 connection
established to "wss://localhost:17072/"
2015-03-20 00:38:13 DEBUG juju.apiserver apiserver.go:273 <- [3]
<unknown>
{"RequestId":1,"Type":"Admin","Version":1,"Request":"Login","Params":"'params
redacted'"}

Note: Version 1 of Login.

I'm hoping this can help anyone coming later identify the problems with
the upgrade tests.

Cheers,
Tim