Reviews on Github

[Dimiter Naydenov]

As long as we can have draft reviews like on RB and not
email-spam-per-comment, totally +1

On 09/14/2016 01:25 PM, Horacio Duran wrote:
> Also +1 for that source not being review board
> 
> On Wed, Sep 14, 2016 at 5:23 PM, Reed O'Brien <reed.obrien at canonical.com
> <mailto:reed.obrien at canonical.com>> wrote:
> 
>     Also +1 for a single source of truth.
> 
>     On Wed, Sep 14, 2016 at 1:20 PM, Rick Harding
>     <rick.harding at canonical.com <mailto:rick.harding at canonical.com>> wrote:
> 
>         /me is always +1 on reducing the number of things we have to
>         maintain and keeping things simpler. 
> 
>         On Wed, Sep 14, 2016 at 4:04 PM Nate Finch
>         <nate.finch at canonical.com <mailto:nate.finch at canonical.com>> wrote:
> 
>             In case you missed it, Github rolled out a new review
>             process.  It basically works just like reviewboard does,
>             where you start a review, batch up comments, then post the
>             review as a whole, so you don't just write a bunch of
>             disconnected comments (and get one email per review, not per
>             comment).  The only features reviewboard has is the edge
>             case stuff that we rarely use:  like using rbt to post a
>             review from a random diff that is not connected directly to
>             a github PR. I think that is easy enough to give up in order
>             to get the benefit of not needing an entirely separate
>             system to handle reviews.  
> 
>             I made a little test review on one PR here, and the UX was
>             almost exactly like working in
>             reviewboard: https://github.com/juju/juju/pull/6234
>             <https://github.com/juju/juju/pull/6234>
> 
>             There may be important edge cases I'm missing, but I think
>             it's worth looking into.
> 
>             -Nate
>             --
>             Juju-dev mailing list
>             Juju-dev at lists.ubuntu.com <mailto:Juju-dev at lists.ubuntu.com>
>             Modify settings or unsubscribe at:
>             https://lists.ubuntu.com/mailman/listinfo/juju-dev
>             <https://lists.ubuntu.com/mailman/listinfo/juju-dev>
> 
> 
>         --
>         Juju-dev mailing list
>         Juju-dev at lists.ubuntu.com <mailto:Juju-dev at lists.ubuntu.com>
>         Modify settings or unsubscribe at:
>         https://lists.ubuntu.com/mailman/listinfo/juju-dev
>         <https://lists.ubuntu.com/mailman/listinfo/juju-dev>
> 
> 
> 
> 
>     -- 
>     Reed O'Brien 
>     ✉ reed.obrien at canonical.com <mailto:reed.obrien at canonical.com>
>     ✆ 415-562-6797 <tel:415-562-6797>
> 
> 
>     --
>     Juju-dev mailing list
>     Juju-dev at lists.ubuntu.com <mailto:Juju-dev at lists.ubuntu.com>
>     Modify settings or unsubscribe at:
>     https://lists.ubuntu.com/mailman/listinfo/juju-dev
>     <https://lists.ubuntu.com/mailman/listinfo/juju-dev>
> 
> 
> 
> 


-- 
Dimiter Naydenov <dimiter.naydenov at canonical.com>
Juju Core Sapphire team <http://juju.ubuntu.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20160914/7e091a35/attachment-0001.pgp>