Build failed in Jenkins: jujugui-test-charm #585

Mon Jul 29 19:48:16 UTC 2013

See <http://10.189.74.2:8080/job/jujugui-test-charm/585/changes>

Changes:

[Rick Harding] Fixes routing issues around search and charm tabs

- See bug #1205468
- See bug #1200743

Summary
-------
There are two problems. The first is that when doing some view state changes
we need to also clear the hash so that it doesn't carry around. We also clear
the charm id when doing searches in fullscreen mode. This helps the browser
app ack that there were changes in state and show the correct view.

The second issue was that clicking a tab on the fullscreen charm details after
a search causes two #bws-readme (for instance) to be added. One is before the
query string and one is after the querysting. This is caused by our double
dispatch and the fact that our routing code builds urls with query strings
after the hash of the url. This is not proper. The Y.App adds it to the end of
the url. In this way we ended up with it in both places.

Our routing code would then assume the whole #bws-readme?text=apache2 was the
hash of the url and that there was no query string. All kinds of trouble came
out of this.

Tests are added to verify the changes work as expected given our sample bad
urls.

QA
---
To QA simpler go through the steps in the two bugs and it should work as
expected. Other QA would be to verify that other usage is not adversely
effected by moving the hash to be at the end of the url while the querystring
is immediately after the path.

R=j.c.sackett, jeff.pihach
CC=
https://codereview.appspot.com/12036043

------------------------------------------
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on lp-quantal-server-amd64
$ bzr revision-info -d <http://10.189.74.2:8080/job/jujugui-test-charm/ws/>
info result: bzr revision-info -d <http://10.189.74.2:8080/job/jujugui-test-charm/ws/> returned 0. Command output: "904 jcsackett at canonical.com-20130729170351-xjgbx34ofjl8x752
" stderr: ""
[jujugui-test-charm] $ bzr pull --overwrite lp:juju-gui
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
http://bazaar.launchpad.net/~juju-gui/juju-gui/trunk is permanently redirected to http://bazaar.launchpad.net/~juju-gui/juju-gui/trunk/changes
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
 M  app/app.js
 M  app/assets/javascripts/ns-routing-app-extension.js
 M  app/subapps/browser/browser.js
 M  app/subapps/browser/views/charm.js
 M  app/subapps/browser/views/view.js
 M  app/widgets/charm-search.js
 M  test/test_browser_app.js
 M  test/test_routing.js
All changes applied successfully.
Now on revision 905.
[jujugui-test-charm] $ bzr revert
$ bzr revision-info -d <http://10.189.74.2:8080/job/jujugui-test-charm/ws/>
info result: bzr revision-info -d <http://10.189.74.2:8080/job/jujugui-test-charm/ws/> returned 0. Command output: "905 rick.harding at canonical.com-20130729193858-xxak6pz6p7ag8b88
" stderr: ""
[jujugui-test-charm] $ bzr log -v -r revid:jcsackett at canonical.com-20130729170351-xjgbx34ofjl8x752..revid:rick.harding at canonical.com-20130729193858-xxak6pz6p7ag8b88 --long --show-ids
Getting local revision...
$ bzr revision-info -d <http://10.189.74.2:8080/job/jujugui-test-charm/ws/>
info result: bzr revision-info -d <http://10.189.74.2:8080/job/jujugui-test-charm/ws/> returned 0. Command output: "905 rick.harding at canonical.com-20130729193858-xxak6pz6p7ag8b88
" stderr: ""
RevisionState revno:905 revid:rick.harding at canonical.com-20130729193858-xxak6pz6p7ag8b88
[EnvInject] - Injecting environment variables from a build step.
[EnvInject] - Injecting as environment variables the properties content 
JUJU_INSTANCE_IP=91.189.93.93
JUJU_BRANCH=lp:juju-gui
JUJU_CHARM=cs:~juju-gui/precise/juju-gui
FAIL_FAST=1
JUJU_GUI_TEST_BROWSERS=ie chrome firefox

[EnvInject] - Variables injected successfully.
[jujugui-test-charm] $ /bin/sh -xe /tmp/hudson5894722514086791034.sh
+ set -ex
+ cat
+ chmod +x /tmp/test-runner
+ sudo -E su -p -c /tmp/test-runner - jujugui-merger
Clean and Prep
2013-07-29 19:41:06,935 INFO Destroying environment 'juju-gui-testing' (type: openstack)...
2013-07-29 19:41:08,383 INFO 'destroy_environment' command finished successfully
WARNING: this command will destroy the 'juju-gui-testing' environment (type: openstack).
This includes all machines, services, data, and other resources. Continue [y/N] 
Lightweight Checkout of lp:juju-gui
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data.  See "bzr help launchpad-login".
JUJU_INSTANCE_IP=91.189.93.93
Running Tests
virtualenv virtualenv --system-site-packages
New python executable in virtualenv/bin/python
Installing distribute.............................................................................................................................................................................................done.
Installing pip...............done.
virtualenv/bin/easy_install archives/selenium-2.33.0.tar.gz
Processing selenium-2.33.0.tar.gz
Running selenium-2.33.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-2sZ2xI/selenium-2.33.0/egg-dist-tmp-DJ10Hd
Adding selenium 2.33.0 to easy-install.pth file

Installed /home/jujugui-merger/gui-branch/virtualenv/lib/python2.7/site-packages/selenium-2.33.0-py2.7.egg
Processing dependencies for selenium==2.33.0
Finished processing dependencies for selenium==2.33.0
ADDRESS	91.189.93.93	i-00008dee
Using image e8f6e1d9-3a8b-4948-b127-242721ce190d (ubuntu-released/ubuntu-precise-12.04-amd64-server-20130624-disk1.img)
Bootstrapping...
Deploying service...
Setting origin for charm to deploy lp:juju-gui
Waiting for service to start...
Assigning JUJU_INSTANCE_IP 91.189.93.93
Storing Internal IP as 10.55.60.171
Assigned IP to i-00008dee
Execution failure, unable to continue
error deploying service
Unable to deploy Charm.
Quitting...
2013-07-29 19:48:12,833 INFO Destroying environment 'juju-gui-testing' (type: openstack)...
2013-07-29 19:48:15,775 INFO 'destroy_environment' command finished successfully
WARNING: this command will destroy the 'juju-gui-testing' environment (type: openstack).
This includes all machines, services, data, and other resources. Continue [y/N] Collected exit code 1
Final instance state
i-00008ded running i-00008dee running
+ cat /home/jujugui-merger/exit-status
+ ec=1
+ [ 0 -eq 1 ]
+ cat /home/jujugui-merger/instance-state
+ wc -l
+ [ 2 -lt 2 ]
+ wc -l
+ grep error\|stopped
+ cat /home/jujugui-merger/instance-state
+ [ 0 -gt 0 ]
+ exit 1
Build step 'Execute shell' marked build as failure