Changing/removing configuration keys for a charm in the charm store.

[Marco Ceppi]

Okay, so taking in Sidnei's feedback I've merged this request as it's
reverting back to a previous state. The example not withstanding I'm
curious on how we should handle such changes in the future.

Thanks, Marco


On Mon, Nov 4, 2013 at 10:53 AM, David Ames <david.ames at canonical.com>wrote:

> On 11/03/2013 05:00 PM, Sidnei da Silva wrote:
> > To be clear, this *specific* change (the rename of a config.yaml
> argument)
> > is a revert of r31 of the charm in the charm store.
>
> Also in this specific case, nagios_check_http_params is the config key
> used in several of the other charms and would be correct to keep squid
> reverseproxy with the standard.
>
> --
> David Ames
>
>
> > On Sun, Nov 3, 2013 at 9:50 PM, Marco Ceppi <marco.ceppi at canonical.com
> >wrote:
> >
> >> Hi all, I need some consensus on how to handle merge proposals for
> charms
> >> in the charm charm store when these proposals change configuration key
> >> names. The proposal in question is
> >>
> https://code.launchpad.net/~sidnei/charms/precise/squid-reverseproxy/trunk/+merge/190500in
> >> the config.yaml diff the following is changed:
> >>
> >>  320- nagios_check_url: 321+ nagios_check_http_params: 322 default: ""
> 323type: string324description: >325-
> >> The URL to check squid has access to, most likely inside your web server
> >> farm 326 + The parameters to pass to the nrpe plugin check_http.
> >>
> >> It's my understanding we do not want to change configuration option
> names
> >> as it will "break" what a user has deployed. Configuration values can be
> >> added, as sane defaults will kick in with that but when it comes to
> >> changing a name it's essentially removing that configuration option and
> >> adding a new one.
> >>
> >> I would recommend in this scenario that nagios_check_url remains and
> >> nagios_check_http_params is added with the change and note of the
> >> distinction of the two in the README.
> >>
> >> I'm actually not sure how to handle this though, so I'm reaching out to
> >> the list for feedback.
> >>
> >> Thanks,
> >> Marco Ceppi
> >>
> >> --
> >> Juju mailing list
> >> Juju at lists.ubuntu.com
> >> Modify settings or unsubscribe at:
> >> https://lists.ubuntu.com/mailman/listinfo/juju
> >>
> >>
> >
> >
> >
> >
>
>
> --
> Juju mailing list
> Juju at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20131104/1816fa5c/attachment.html>