[Review Queue] elasticsearch adding ufw support

[Matt Bruzek]

Today I had the chance to review the ufw changes for the trusty
elasticsearch charm. The elasticsearch charm is a really good example of a
charm that uses Ansible ( http://www.ansible.com/home ). Even though I am
not an Ansible expert, I was able to follow along.


 The change involved adding support for ufw (Uncomplicated FireWall) to the
charm and adding rules around the ports 9200 and 9300. I would recommend
the trusty elasticsearch charm as a great example of how to do firewalls if
anyone else needs to use firewall rules in their charms.


 Michael Nelson did a very good job of providing guidance on how to test
the changes. I ended up deviating from the steps, but I really appreciated
having a place to start with the testing. Thank you Michael for including
testing steps in your merge proposal, that was much appreciated and sped up
the review process for me. The more testing/verification instructions in
the merge proposals will help speed up the reviews that we are behind on.
So if you are reading this and do not have test/verification steps in your
merge proposal please add them!


 The new elasticsearch charm is available here:

http://manage.jujucharms.com/charms/trusty/elasticsearch


 Thanks,


 - Matt Bruzek <matthew.bruzek at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20140819/7d474e35/attachment.html>