[Review Queue] python-django, rabbitmq-server, nrpe

[Kevin Monroe]

Hello friends!  Amir, Cory, and I had some 'que last week:

+ python-django
https://code.launchpad.net/~nicopace/charms/trusty/python-django/allowed_host_patch/+merge/254958

This was a bugfix MP from Nico.  An empty config option was not being
handled correctly, resulting in page request failures.  Nico fixed this by
properly setting defaults when the config option is empty, and we were able
to verify successful page requests with his changes merged.  +1

+ nrpe
https://code.launchpad.net/~gnuoy/charms/trusty/nrpe/services-rewrite/+merge/253799
https://bugs.launchpad.net/charms/+bug/1430732

This is a trusty rewrite for precise/nrpe-external-master and the current
trusty/nrpe.  We consolidated the bug and MP into a single review queue
item with future discussion about this charm taking place in the MP.  There
are a couple lint and test issues that Adam has raised in the bug, but the
refactor looks good overall.  We were successful in using nrpe from this
branch in testing a rabbitmq MP (below).  Once lint and test have been
resolved, we're confident in giving our +1.

+ rabbitmq-server
https://code.launchpad.net/~thedac/charms/trusty/rabbitmq-server/queue-monitoring/+merge/255025

This MP adds support for queue monitoring by nagios. This is dependent on
the Trusty rewrite of nrpe (above) -- we were able to get the included test
to pass using the nrpe branch under review.  That said, we'd like to see
the manual instructions encapsulated in an Amulet test so auto-testing can
exercise this functionality. We also noted 2 upstream bugs, and while
they're not directly related to this MP, they will need to be fixed to get
this charm 100% passing.

Thanks!
-Kevin Monroe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150406/af91097b/attachment.html>