[Review Queue] nagios, relatime-syslog-analytics,bip, squid-forwardproxy, and Zulu8

[MrAsanjar .]

Howdy!  The Big Data team ( Cory/Kevin/Amir/Andrew ) did some RQ time
together today:




* - nagios (add-extra-config) Overall, new changes look good particularly
switch to a template for the config files makes it easier to follow.
However, we did run into some issues when running the tests.-
https://code.launchpad.net/~brad-marshall/charms/trusty/nagios/add-extra-config-options/+merge/265480
<https://code.launchpad.net/~brad-marshall/charms/trusty/nagios/add-extra-config-options/+merge/265480>-
00-setup test needs “sudo” on “apt-get update”- There were some test
failures from the upstream charm, unrelated to this review (seems to be
covered by https://bugs.launchpad.net/charms/+source/nagios/+bug/1403574
<https://bugs.launchpad.net/charms/+source/nagios/+bug/1403574> but seemed
worth mentioning, at least)- Newly added test seems to have a bit of a race
condition; suggested a work-around- New bundle:  realtime-syslog-analytics-
https://jujucharms.com/q/realtime/syslog/analytics
<https://jujucharms.com/q/realtime/syslog/analytics>- +1 on review - This
bundle won’t deploy correctly until the apache-flume-* charms are
promulgated.- bip charm:- https://bugs.launchpad.net/charms/+bug/1401774
<https://bugs.launchpad.net/charms/+bug/1401774>- +1 looked good, tests
passed, just needs minor changes to README.md file- missing “contact”
information.- squid-forwardproxy-
https://code.launchpad.net/~jose/charms/precise/squid-forwardproxy/fix-readme-link/+merge/266684
<https://code.launchpad.net/~jose/charms/precise/squid-forwardproxy/fix-readme-link/+merge/266684>-
+1 minor update to the README.md, approved - Zulu8-
https://bugs.launchpad.net/charms/+bug/1477661
<https://bugs.launchpad.net/charms/+bug/1477661>- -1, Install hook failed-
missing test- charm should be subordinate - needs more info in README.md*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150806/16a67e4a/attachment.html>