[Review Queue] mongodb, cassandra, ubuntu-repository-cache

[Matt Bruzek]

Charles Butler and I spent some time reviewing charms that were in the
Review Queue.

We process the queue top down, so the oldest charms first.  Here is a
summary of what we found with links to the merge proposals for more details.

*mongodb *

   -
   https://code.launchpad.net/~tvansteenburgh/charms/trusty/mongodb/use-charm-benchmark-lib/+merge/278044
      - Adding the "charmbenchmark" code to mongodb.
      - Problem: charmbenchmark is now "charms.benchmark"
      - Tests fail.  Needs Fixing. Moved on the other two mongodb proposals.
   -
   https://code.launchpad.net/~aisrael/charms/trusty/mongodb/update-benchmarking/+merge/278626
      - Updates to the perf action and adding benchmark relation hooks.
      - +1 merged.
   -
   https://code.launchpad.net/~evarlast/charms/trusty/mongodb/fix-dump-actions/+merge/277191


   - Fixing the dump action to use shlex library to escape spaces.
   - 03_deploy_replicaset.py - “# We assume minimum unit number is master.”
   - seems wrong to me, commented about it in the review.
   - The tests passed on amazon:  PASS: 9 Total: 9 (2718.376073 sec)
   - This proposal also improved the `charm proof` output and how the
   sentry units are indexed.  While not perfect, this was an overall
   improvement which earned my +1, merged.

*cassandra-spike*

   -
   https://code.launchpad.net/~stub/charms/trusty/cassandra/spike/+merge/276372
      - Test updates, behavior change in tests
      - +1 merged

*cassandra-noauth*

   -
   https://code.launchpad.net/~stub/charms/trusty/cassandra/noauthentication/+merge/275863
      - Allow use of the AllowAllAuthenticator, turning off authentication
      entirely. This is needed for legacy applications which have no
facility to
      provide authentication credentials.
      - +1 Merged

*ubuntu-repository-cache*

   -
   https://code.launchpad.net/~james-page/charms/trusty/ubuntu-repository-cache/landing/+merge/279004
      - +1 the proposed merge, in turn discovered and filed a bug against
      the charm due to CI test failures -
      https://bugs.launchpad.net/charms/+source/ubuntu-repository-cache/+bug/1526928


Thanks,

   - Matt Bruzek <matthew.bruzek at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151216/ce27388c/attachment.html>