[Review Queue] - cassandra (x2), ethercalc, IBM XLC/C++, New Charm: minecraft, Saiku Enterprise Analytics

[Konstantinos Tsakalozos]

Hi,

The Big Data team spent some time on the review queue. Here's what we came
up with:


   -

   cassandra/noppa
   -


      https://code.launchpad.net/~stub/charms/trusty/cassandra/noppa/+merge/278097
      -

      The proposed MP contains significantly more changes than the PPA
      config option mentioned, and the tests added tests seem to be
timing out.
      Replied asking for more information on the changes and
suggestion on how to
      get the tests to run in a reasonable timeframe.
      -

   cassandra/rsync-port
   -


      https://code.launchpad.net/~stub/charms/trusty/cassandra/rsync-port/+merge/278671
      -

      We reviewed the code and found no issues.
      -

      The tests are running for hours and that makes the review process
      hard.
      -

      The automated test execution shows no problems. When we run the tests
      locally we got a single time out failure.
      -

      A request for tests that run in reasonable times has been placed as
      part of a previous review. This specific patch seems ok.
      -

      We can proceed with the merging.
      -

   ethercalc
   -

      https://bugs.launchpad.net/charms/+bug/1486247
      -

      With confirmation that the copyright is being voluntarily assigned to
      Canonical, I have promulgated this charm
      -

   IBM XLC/C++
   -

      https://bugs.launchpad.net/charms/+bug/1489829
      -

      Successfully deployed per readme instructions and bundletester tests
      passed.
      -

      Minor tweaks made to the hooks (chmod +x) and the readme to note a
      convenient location to view the trial license.
      -

      During review, we discovered an IBM PPA that would shrink the charm
      size considerably, so we offered a merge proposal to install from PPA vs
      local ./files/archive.
      -


         https://code.launchpad.net/~kwmonroe/charms/trusty/ibm-xlc/bug1489829/+merge/280933
         -

   New Charm: minecraft
   -

      lp:~mattyw/charms/trusty/minecraft/trunk
      -

      This is one of the first charms to go under review and use layers. We
      came across a few issues that need fixing before actually giving
the green
      light for this charm. In particular:
      -

         The charm submitted under review  is the output of “charm build”,
         yet the testing process in place is trying to call “charm build” again.
         -

         Even though we would prefer to review the layers and not the final
         charm, the buildtester does not include a charm build step.
         -

      We contacted the author and we are waiting for his feedback/fixes.
      -

   Saiku Enterprise Analytics
   -

      https://bugs.launchpad.net/charms/+bug/1524715
      -

      First test deploys to lxc which causes problems further on in the
      test with public-address when using bundletester and a specific
environment
      (AWS in this case)
      -

      Legacy test code tomcat_unit = d.sentry['tomcat/0'] should be changed
      to d.sentry[‘tomcat’][0]
      - Charm proof failures - comments left in bug for author to resolve.



For any comments and questions you can find us on #juju on irc.freenode.net


Thank you
-- 
Konstantinos Tsakalozos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151218/1f0e77ab/attachment.html>