[Review Queue] ksplice, and python-django

Cory Johns cory.johns at canonical.com
Wed Feb 4 14:51:42 UTC 2015


Kevin and I worked together yesterday to review a new charm submission
for KSplice / Uptrack [1], and a merge proposal to (re?)add
pip_extra_args support to the trusty python-django charm [2].

The KSplice charm had an issue with the provided test requiring manual
input, which would break the automated test runner.  We also suggested
a few possible cleanups, by better leveraging more of charmhelpers
(the charm did use some charmhelpers, but there were more that could
be taken advantage of to reduce some of the code in the charm).

The merge proposal for python-django unfortunately failed the existing
tests, by enabling processing of a setting in the tests that was
previously being ignored.  We suggested a possible way to fix the test
to get the MP passing.

[1]: https://bugs.launchpad.net/charms/+bug/1414204
[2]: https://code.launchpad.net/~codersquid/charms/trusty/python-django/pip-extra-args/+merge/245785



More information about the Juju mailing list