[Review Queue] nuage-vsd, nuage-vsc, nuage-vrs

[Adam Israel]

There are three Nuage-related charms in the queue that I reviewed today: [1] nuage-vrs, [2] nuage-vsc, and [3] nuage-vsd.

Common Issues

charm proof

All three charms suffer from a variety of charm proof warnings. These should be easy fixes.

make lint

All three charms generate several lint errors. Most of these are related to whitespace issues, with the outliers possibly leading to unexpected behaviour.

unit tests

nuage-vsd has the most developed tests of the three, but fails via automated and manual testing.

Once these issues are fixed, more in depth testing can be done under OpenStack.

[1] https://bugs.launchpad.net/charms/+bug/1420995

[2] https://bugs.launchpad.net/charms/+bug/1420994

[3] https://bugs.launchpad.net/charms/+bug/1420997




-- 
Adam Israel
Sent with Airmail
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150218/d0a2a917/attachment.html>