[Review Queue] cleaning house, nagios, zookeeper

[Kevin Monroe]

Hi folks,

Amir, Cory, and I had a delightful time in the queue today:

+ cleaning house
    Nicolás (~nicopace) did a great job adding new tests to lots of
charms.  These were originally submitted as individual Merge Proposals, but
later consolidated into a single MP per charm.  This decreased the time
required per review, but also left the queue dirty as many items were
subsumed by corresponding consolidated MPs.  Kevin commented/flagged about
20 of these so future reviewers know to disregard until they fall off the
list.

+ nagios (new tests)

https://code.launchpad.net/~nicopace/charms/trusty/nagios/all-tests/+merge/251286
    - Amir had an issue with a missing default series in the extant
100-deploy test, but it was fixed upstream and resolved when we did a
proper branch + merge instead of just branching the MP branch.
    - There were a couple issues with the SSL tests and it seems like the
tests could use more calls to sentry.wait() to ensure consistent results;
we commented on these issues and marked the review as Needs Fixing.

+ zookeeper / hdp-zookeeper (new tests)

https://code.launchpad.net/~nicopace/charms/trusty/zookeeper/all-tests/+merge/251313
    - Cory merged these tests into hdp-zookeeper since the referenced
zookeeper charm is obsolete.
    - A request to remove the obsolete charm from the store was submitted.

Have a great weekend!
-Kevin Monroe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20150227/76e1fedc/attachment.html>