[Review Queue] precise/haproxy
Tim Van Steenburgh
tim.van.steenburgh at canonical.com
Fri Nov 6 13:52:32 UTC 2015
Reviewed
https://code.launchpad.net/~jacekn/charms/precise/haproxy/haproxy-updates/+merge/272559
This branch makes a few improvements to the precise/haproxy charm:
- add SSL support
- add nagios_servicegroups config option
- multiple monitoring fixes
- add open_monitoring_port option
Changes looked good, although there were proof, lint, and unit test errors
(deploy tests were successful) not related to the changes. I created a new
branch containing test fixes (
http://reports.vapour.ws/charm-test-details/charm-bundle-test-parent-3392) and
proposed it for merging. The original changes will be merged once the fixes
land.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151106/051b82a0/attachment.html>
More information about the Juju
mailing list