Missing contrib.amulet in charm-helpers-hooks

[James Beedy]

Openstack-Charmers,

I am hitting an error when shared-db-relation-changed executes, where it cannot create a logger due to https://bugs.launchpad.net/charms/+source/glance/+bug/1509540 <https://bugs.launchpad.net/charms/+source/glance/+bug/1509540>. I found the cause of this issue, and is such that contrib.openstack.amulet.utils.py tries to import ‘charmhelpers.contrib.amulet.utils.AmuletUtils’ and fails because it doesn’t exist, because it hasn’t been pinned in charm-helpers-hooks.yaml.

I have been under the impression (until now) that charm-helpers modules should not depend on other charm-helpers modules, until recently when a little bird hinted to me that exceptions are being made to this standard so that we can override some of the tooling to fit openstack use cases. In the case that this exception has been made, and this (http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/openstack/amulet/utils.py#L34 <http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/openstack/amulet/utils.py#L34>) is a legitimate import, it seems ‘contrib.amulet’  would need to be pinned in charm-helpers-hooks.yaml for any charm that pins "contrib.openstack|inc=*” or “contrib.openstack.amulet”. In the case that modifying charm-helpers-hooks.yaml to include ‘contrib.amulet’ is the correct modification to make, I have created MR's for each charm that needs these modifications. Also, I have synced charm-helpers and made MR’s on all charms (even those that don’t need ‘contrib.amulet’ pinned) to ensure they all have consistent charm-helpers libs.

What I’m wondering is:

A. Is http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/openstack/amulet/utils.py#L34 <http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/openstack/amulet/utils.py#L34> legitimate?
B. Is the fix, as well as the way I have applied it, what you would consider to be the correct modification, and procedure to be made to fix this issue?

Thanks in advance for your insight,

James
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151026/bd46b212/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151026/bd46b212/attachment.pgp>