[Review Queue] collectd, and prometheus

[Matt Bruzek]

I reviewed the collectd and prometheus charms today. The reactive code is
very well written and both charms deployed correctly.

The charms still had the basic auto-generated tests, and the readme files
were VERY minimal. Both charms would fail the lint step on bundletester
(our automated testing tool), so I sent the review findings to the authors
and expect they will be easy fixes for the authors.

Very well written charm code, if you are looking for an example of some
great reactive code look no further than:
https://jujucharms.com/u/prometheus-charmers/collectd
https://jujucharms.com/u/prometheus-charmers/prometheus

That is all,

   - Matt Bruzek <matthew.bruzek at canonical.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160803/d5db648c/attachment.html>