[Review Queue] IBM WAS Base, IBM Websphere Liberty, MySQL, Squid Reverse Proxy, Bip IRC Proxy, Ghost

Thu Dec 1 20:26:48 UTC 2016

Hi All,

The Big Data team (Konstantinos, Kevin, Cory and Pete) took a trip through
the review queue today, with a focus on wrapping things up in the old
queue, and preparing to move things to the new queue. Here's what we did:

   -

   IBM WAS Base
   -

      https://review.jujucharms.com/reviews/34?revision=70
      -

      Reviewed the source and found a couple small issues:
      -

         README needs to use “juju config” instead of “juju set”
         -

         Charm is exclusive to s390x, but it appears WAS supports the other
         arches. Recommended removing the s390x condition
         -

   IBM Websphere Liberty
   -

      https://review.jujucharms.com/reviews/26?revision=60
      -

      Requested design doc review.  Looks good, so +1 to move forward with
      coding.
      -

      We imported the latest charm revision so code review can begin.
      -

   MySQL
   -

      https://code.launchpad.net/~jillrouleau/charms/trusty/mysql/raise-max-conns-lp1382386/+merge/303638
      -

      The upstream for this charm has changed.  I contacted the maintainer
      to have them close out the old repository, and requested that
the change be
      resubmitted against the new repo.  However, the change in itself
seems fine
      and has my +1
      -

   Squid Reverse Proxy
   -

      https://code.launchpad.net/~dbuliga/charms/trusty/squid-reverseproxy/centos/+merge/287481
      -

      Started the process of moving it to the new review queue (created a
      ~squid-team on launchpad, and pinged the maintainers, requesting
that they
      move the code there).
      -

   Bip IRC Proxy
   -

      https://code.launchpad.net/~josvaz/charms/trusty/bip/client_side_ssl-with_helper-lp1604894/+merge/301802
      -

      Created the launchpad team to handle this charm and move it out of
      charmers.
      -

      Contacted the maintainer about the changes involved in using the new
      review queue.
      -

   Ghost
   -

      https://review.jujucharms.com/reviews/21
      -

      Test was still failing due to wrong key in tests.yaml, but Adam
      worked with me to get everything sorted and it’s now released!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20161201/8c5e4f22/attachment.html>