[Review Queue] apache2, cassandra, haproxy, ibm-java-sdk, midonet-gateway

[Cory Johns]

Hello all.  The Big Data Team (myself, Kevin, Andrew, and Kostas) spent
some time last week on the review queue:

Feb 25, 2016: Andrew/Cory/Kevin/Kostas

   -

   apache2 (add apt config options)
   -


      https://code.launchpad.net/~evarlast/charms/trusty/apache2/trunk/+merge/278220
      -

      This feature has been plagued with unrelated apache test failures for
      a while now.  These have all been resolved!
      -

      The latest updates merged cleanly, tests passed, and we verified apt
      config settings are working as expected.
      -

      +1, merged.
      -

   cassandra (thrift)
   -


      https://code.launchpad.net/~stub/charms/trusty/cassandra/ensure-thrift/+merge/279869
      -

      This merged, but the change in how the config option is handled
      created issues with other charms depending on this one, which also had to
      be reviewed and merged as well:
      -


         https://code.launchpad.net/~celebdor/charms/trusty/midonet-api/cassandra/+merge/287334
         -


         https://code.launchpad.net/~celebdor/charms/trusty/neutron-agents-midonet/cassandra/+merge/287336
         -


         https://code.launchpad.net/~celebdor/charms/trusty/midonet-agent/cassandra/+merge/287338
         -

   haproxy-updates
   -


      https://code.launchpad.net/~jacekn/charms/precise/haproxy/haproxy-updates/+merge/272559
      -

      The previous comments refer to broken tests which now all pass first
      run, Approved.
      -

   ibm-java-sdk
   -

      https://bugs.launchpad.net/charms/+bug/1477067
      -

      Provided some small suggested improvements via a MR
      -

   midonet-gateway
   -

      https://bugs.launchpad.net/charms/+bug/1541735
      -

      The charm did not include any tests. There was no clear way to deploy
      the charm using only information from the readme file. There was no
      description on how to see the effects of the charm after deployment.
      - We asked the author to address the above points. We cannot move on
      with this charm at the moment.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160229/4032d155/attachment.html>