[Review Queue] Tomcat, SpagoBi, xl c/c++, Minecraft, postgresql, ibm-db2

[Andrew Mcleod]

Hello!

Yesterday, Corry, Kevin, Konstantinos and I had our combined review queue
session, and here are the notes:


   -

   tomcat
   -

      https://bugs.launchpad.net/charms/+source/tomcat/+bug/1538715
      -

      Community request to have a webapp-container subordinate relation.
      This keeps subs from having to relate using juju-info, and it offers
      additional data (like webapp install path) that wouldn’t be
available over
      juju-info.
      -

      +1 and pushed. Updated tomcat charms for precise/trusty that offer
      this relation are now available in the store.
      -

   spagobi
   -

      https://bugs.launchpad.net/charms/+bug/1534497
      -

      We cannot proceed with this charm at the moment because of the
      following reasons
      -

         there are no tests validating the operational aspects of the charm
         -

         charm proof test is failing since some required items are missing
         (eg copyright file)
         -

      We deployed the charm using the instructions in the README but we
      couldn't reach to a web interface. We spotted a number of errors in the
      logs and we asked the charm author to review them.


   -

   xl c/c++
   -

      https://bugs.launchpad.net/charms/+bug/1489829
      -

      Recent code changes look great, but we are unable to test this charm
      at the moment while we wait for our ppc64le hardware to become available.
      -

   Minecraft charm
   -

      https://bugs.launchpad.net/charms/+bug/1523896
      -

      This is the second round of reviewing this charm. The author
      addressed the comments we had.
      -

         all tests pass
         -

         the layer that builds the charm is provided here:
         https://github.com/mattyw/minecraft-charm
         -

      +1 with moving forward with this charm
      -

   postgresql (fix max connections)
   -


      https://code.launchpad.net/~stub/charms/trusty/postgresql/fix-max-connections/+merge/282974
      -

      Had some issues with tests due to tester running juju 1.26 alpha3 -
      downgraded and all tests passed, +1 approved.
      -

   ibm-db2
   -

      https://bugs.launchpad.net/charms/+bug/1477057
      - All review items have been addressed and the charm has been
      promulgated.



have a great weekend!
Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160129/2fc90fe4/attachment.html>