[Review Queue] Abot, Rabbitmq-server, IBM, and npm-app

[Konstantinos Tsakalozos]

Hi everyone,


The big data team (Kevin, Pete, Andrew and me) got together to do some
reviews:


June 16, 2016: Kevin/Kostas/Pete/Andrew

   -

   Abot
   -

      https://bugs.launchpad.net/charms/+bug/1582176
      -

      The initial version of the Test Automation Framework charm
      -

      We found some issues that call the attention of the author:
      -

         No tests present
         -

         Readme improvements
         -

         No charm pushed for us to promulgate
         -

      We cannot proceed with the charm at this point.
      -

   Rabbitmq-server
   -


      https://code.launchpad.net/~ben-kaehne/charms/trusty/rabbitmq-server/statsfix/+merge/290949
      -

      `make lint` and `make test` fail
      -

      Lots of tests failing, left a comment
      -

   IBM Base Layer
   -

      https://bugs.launchpad.net/charms/+bug/1584507
      -

      Didn’t see any code to review; moving to Incomplete
      -

   IBM Installation Manager
   -

      https://bugs.launchpad.net/charms/+bug/1575746
      -

      Waiting for decision on our MP; moving to In Progress
      -

   Interface for ibm-db2
   -

      https://bugs.launchpad.net/charms/+bug/1578167
      -

      We made a few lint, format, and doc updates.
      -

      Overall, +1, the db2 interface is published and available on
      http://interfaces.juju.solutions/
      -

   IBM DB2
   -


      https://code.launchpad.net/~ibmcharmers/charms/trusty/ibm-db2/trunk/+merge/294153
      -

      Because of interface state name changes above, this MP needed to be
      updated.  We made the needed changes and asked that those be verified
      before proceeding with promulgation.
      -

   New IBM NFSStorage interface
   -

      https://bugs.launchpad.net/charms/+bug/1578166
      -

      Gave an initial +1, based on a read-through of the code.
      -

   New Charm: npm-app
   -

      https://bugs.launchpad.net/charms/+bug/1572326
      -

      Pinged the submitter, asking how he would like to proceed (we left a
      question for him two weeks ago).


Cheers,
Konstantinos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20160617/1ed4ce63/attachment.html>